Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in multiplayer mode #27

Open
p1230 opened this issue Feb 24, 2022 · 11 comments
Open

Bugs in multiplayer mode #27

p1230 opened this issue Feb 24, 2022 · 11 comments

Comments

@p1230
Copy link

p1230 commented Feb 24, 2022

Hi. First of all thank you for continuing this great project!

I played two games in multiplayer mode (v0.5.3-alpha4, demo settlers III files, new java, one linux and one win10 device, 1+1 team vs. 4 AI's not in a team, all players were Römer).

One bug in the first game (also in the second): When we quit the game, in client's statistics everyone was named "Human". The host's (= my) table was correct (2x Human and 4x Ai[...]). Everything else was fine. In the second game, some bugs appeared:

  • my teammate had Pioniere walking around although he didn't create one manually (maybe even in my color, but we couldn't figure that out later). Anyway he had >10 Pioniere in his overview.
  • I couldn't see the explorations of these Pioniere (lifting fog of war). He could.
  • I could see his territory with people (soldiers etc.) and vice versa but when he later moved most of his troops to my territory I didn't see them but 3 or 4 of them there - and vice versa. Instead I saw his troops still around his Kaserne.
  • In the following fight I fought an enemy's tower my teammate didn't even see (grassland in his case).

edit: I have to add that the connection was probably lost at a time in the second game. Maybe that could explain something.

@paulwedeck
Copy link
Owner

Hello,

edit: I have to add that the connection was probably lost at a time in the second game. Maybe that could explain something.

Yes, this explains most of it.
There is atm no way to recover from a connection loss.
The other player(s) should still be able to continue the game but there is currently no way for him to rejoin.
One thing that surprises me is that his game didn't immediately freeze which is probably very misleading.

@p1230
Copy link
Author

p1230 commented Feb 24, 2022

I think it happened while we paused the game. Maybe a permanent note about the (former) connection loss would be good as a first step.

@paulwedeck
Copy link
Owner

In my tests pausing the game does not lead to a desync or any issue at all.
That might be a strange question but what exactly do you mean with connection loss?
In what way have you noticed the connection loss?

@paulwedeck
Copy link
Owner

paulwedeck commented Feb 24, 2022

Maybe a permanent note about the (former) connection loss would be good as a first step.

The relation between the server and its clients is quite rudimentary at the moment.
As you might have noticed the clients are not even aware which player is AI or human controlled.

@p1230
Copy link
Author

p1230 commented Mar 8, 2022

Pausing is fine I think, I just took into consideration that it happened while it was paused (not stating a causality).

We had a similar issue again, now I took a screenshot. An odd bunch of pioneers, the lifting fog of war was again only to be seen by the client player. This time it happened quite early in the game (maybe from the beginning?). I can't tell more about a possible connection loss because I don't know how to find out whether there is a connection loss, especially in retroperspective.

Nevertheless, 80-90 % of multiplayer games work fine
pioniere
.

@paulwedeck
Copy link
Owner

The game should have created two files. One is called _out.log and the other is called _replay.log. There in a directory called logs/. Could you send me these files from all clients?

@paulwedeck
Copy link
Owner

From what I can see the game lasted around 10 minutes and just before that the red player left and a couple of seconds later the other player left.
I am pretty sure that no desync or anything special happened up until this point.
I can't find this map neither in my s3 folder nor on map base.
If you are sure that this replay is the correct one please also send me the map.

@p1230
Copy link
Author

p1230 commented Mar 8, 2022

The map is https://www.siedler-maps.de/s3maps/download-1305.htm , but the situation described also happened with "Nice Map" (just to point out that it is not because of the map). The files are correct, we quit after taking the screenshot because of the issue.

@paulwedeck
Copy link
Owner

sorry. Discord seams to have an outtake.
I didn't need your map because I thought that its a bug with this particular map but because I otherwise can't replay your match.
Yes I can reproduce your bug and from what I can see both replay differ right from the start which is something I have never seen before

@paulwedeck
Copy link
Owner

The reason for this difference appears to be a bug in the replay tool.
From what I can see now both replay files are exactly the same except that one is for player 1 and the other is for player 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants