Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AA Service URLs to Networks Table #386

Open
chibie opened this issue Jan 16, 2025 · 17 comments · May be fixed by #419
Open

Move AA Service URLs to Networks Table #386

chibie opened this issue Jan 16, 2025 · 17 comments · May be fixed by #419

Comments

@chibie
Copy link
Contributor

chibie commented Jan 16, 2025

User Story
As a backend developer, I want to store bundler and paymaster URLs in the networks table so that new networks can be added without code changes and URLs can be updated via the database.

Acceptance Criteria

  1. GIVEN the networks table is updated
    WHEN checking its schema
    THEN it should have new columns for bundler_url and paymaster_url

  2. GIVEN a new network is added
    WHEN specifying its AA service URLs
    THEN they should be configurable via database entry

  3. GIVEN the code changes are deployed
    WHEN getting AA service provider details
    THEN it should be inferred from the supported URL patterns ("api.stackup", "api.biconomy", or "api.pimlico")

Tech Details

  • Add new columns to networks table:

    • bundler_url (string, optional)
    • paymaster_url (string, optional)
  • Update Network entity (ent/schema/network.go):

    • Add new fields to Network.Fields()
    • Bundle migration with existing networks data
  • Update userop.go:

    • Remove URL lookups from Configuration struct
    • Fetch URLs from database in getEndpoints()
    • Add URL pattern check for supported AA services: stackup, pimlico, biconomy
    • Update error messages for clarity
  • Generate ent migration file for postgres db (refer https://entgo.io/docs/getting-started#generating-migrations)

Notes/Assumptions

  • AA service provider can be detected from URL patterns for Stackup, Biconomy, and Pimlico
  • Existing networks will need their AA details migrated
  • Not all networks will have AA service enabled
  • Maintain backward compatibility during migration

Open Questions

  • What happens if a URL doesn't match any of the supported AA service patterns?
@olisaagbafor
Copy link

olisaagbafor commented Jan 20, 2025

@chibie I'd like to take this issue.

@stephenson080
Copy link

I’m interested in this one.

@chiscookeke11
Copy link

I’d like to resolve this.

@0xprinc
Copy link

0xprinc commented Jan 22, 2025

May I take this issue on?

@demola234
Copy link

Could I take a shot at this?

@Nityam573
Copy link

Can I tackle this one?

@pheobeayo
Copy link

Can I take care of this issue?
I am a Web3 front-end developer skilled in technical documentation and software development. I greatly understand technologies like JavaScript, Typescript, Cairo, Rust and Solidity. I have contributed successfully to open-source projects like Stark Quest, Bandada and Speedrun scaffold-stark

@vestor-dev
Copy link

Holla i'm Vestor, I'm an experienced frontend developer and a smart contract developer and i would love to take on this issue.
Kindly assign :) and i'll get to work

@Wendyalbert
Copy link

Can I take this from here?

@13x54n
Copy link

13x54n commented Jan 22, 2025

May I pick this up?

@Supa-mega
Copy link

I’d like to work on this.

@Zkaskar
Copy link

Zkaskar commented Jan 23, 2025

Hey team, this is going to be my first ODboost this time.
I would love to work with Paycrest, this issue i believe i can submit the PR in 4 days realistically.
Waiting for kind approval

@Atanda1
Copy link
Collaborator

Atanda1 commented Jan 23, 2025

Hi everyone,

This issue will be assigned soon. We are working to resolve a bug on the repo, after which it'll be assigned.

@Amizeey
Copy link

Amizeey commented Jan 23, 2025

Is this issue still available?

@Atanda1
Copy link
Collaborator

Atanda1 commented Jan 24, 2025

Could I take a shot at this?

@demola234 This ticket is assigned to you.

@chibie
Copy link
Contributor Author

chibie commented Jan 28, 2025

@demola234 have you started work on this ticket?

@JuViquez
Copy link

JuViquez commented Feb 5, 2025

May I take this issue on?

@sundayonah sundayonah self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.