Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy & document a secure payjoin-relay subdirectory naming scheme #130

Closed
DanGould opened this issue Dec 11, 2023 · 2 comments
Closed
Labels
documentation Improvements or additions to documentation payjoin-directory

Comments

@DanGould
Copy link
Contributor

Right now payjoin-relay assigns per-session subdirectories by taking the first few characters of an arbitrary receiver specified base64 encoded pubkey. I'm not sure if these are as unique as the characters if for example base64 or the underlying pubkey has a header. Ensure we have unique keys and few collisions, which would be an annoying DoS. Perhaps a hash of the pubkey would be suitable.

@DanGould DanGould added this to the Payjoin V2 beta milestone Dec 11, 2023
@DanGould DanGould changed the title Document a secure payjoin-relay subdirectory naming scheme. Document a secure payjoin-relay subdirectory naming scheme Dec 11, 2023
@DanGould DanGould changed the title Document a secure payjoin-relay subdirectory naming scheme Deploy & document a secure payjoin-relay subdirectory naming scheme Dec 11, 2023
@DanGould DanGould added the documentation Improvements or additions to documentation label Dec 11, 2023
@DanGould
Copy link
Contributor Author

This is closed by #386

Please ack @nothingmuch

@nothingmuch
Copy link
Collaborator

I think so, the analysis of the collision resistance properties is completed.

That said #389 will still likely affect this in one more way, if the short ID is also encoded using the bech32 character set. Posting the details there, not sure if this means this issue should still be open, as the behavior is already merged (the directory already decodes the path component and recovers the 8 bytes of unique ID and uses them in their entirety as the underlying key)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation payjoin-directory
Projects
Status: Done
Development

No branches or pull requests

2 participants