Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage in CI #381

Closed
spacebear21 opened this issue Oct 30, 2024 · 3 comments
Closed

Add code coverage in CI #381

spacebear21 opened this issue Oct 30, 2024 · 3 comments

Comments

@spacebear21
Copy link
Collaborator

Ideally we should pick a tool that shows visual line-by-line code coverage, so we can easily determine which code paths need more robust testing.
@DanGould
Copy link
Contributor

I admit I have no experience with these tools. Any suggestions?

@spacebear21
Copy link
Collaborator Author

I used coverage.py with GitLab in the past which was nice but I'm not really familiar what the rust/GitHub options. I talked to @0xBEEFCAF3 about it briefly last week and he mentioned codecov (I'm pretty sure it was codecov...). rust-bitcoin uses coveralls, e.g. rust-bitcoin/rust-bitcoin#3481 (comment)

Not a high priority addition but I noticed it in the README milestones and it might help highlight untested code paths in PR reviews, so I wanted to track it somewhere.

@spacebear21
Copy link
Collaborator Author

Closed by #385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Payjoin Roadmap 📝
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanGould @spacebear21