Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary services/config calls or empty response #2

Open
Tomgroot opened this issue Oct 25, 2024 · 1 comment
Open

Unnecessary services/config calls or empty response #2

Tomgroot opened this issue Oct 25, 2024 · 1 comment

Comments

@Tomgroot
Copy link

In sendRequestMultiCore, the services/config endpoint is called to fetch the tgu domains. How should we handle the unnecessary calls this will generate? Currently, this endpoint returns an empty response, which will skip the request altogether.

Would the approach here be suitable: https://github.com/opentickettech/paynl-omnipay/pull/1/files? In it, tguDomain is passed as a parameter to the request, and a tgu domain list is built (somewhat "hard-coded") from this.

@NickHes
Copy link
Collaborator

NickHes commented Oct 26, 2024

@Tomgroot thanks for your suggestion and PR. Your reasoning is sound. The team is going to take a look at this early next week and merge it upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants