Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong input field #57

Open
tajriba opened this issue Mar 6, 2024 · 4 comments
Open

wrong input field #57

tajriba opened this issue Mar 6, 2024 · 4 comments

Comments

@tajriba
Copy link

tajriba commented Mar 6, 2024

when using chrome/firefox the api key is stored in a password field type input. this is not good, because when editing the module configuration the key is always gone... because it's not a saved password:

solution: No password field
Scherm­afbeelding 2024-03-06 om 13 57 08

@venditdevs
Copy link

You are incorrect.
Yes it's empty when you open the configuration screen again but it's still saved in the database. and when you save the configuration again the data in the database doesn't get overwritten by the empty one if you look at the code of the module.

if (!empty(Tools::getValue('PAYNL_API_TOKEN'))) { Configuration::updateValue('PAYNL_API_TOKEN', Tools::getValue('PAYNL_API_TOKEN')); }

@tajriba
Copy link
Author

tajriba commented Mar 8, 2024

In the real world it's working not good in Firefox for example.
The field is empty and after saving the configuration failed and empty field is saved.

@annevelden
Copy link
Contributor

Thank you for your comment @tajriba however @venditdevs is correct that we have made modifications so an empty field doesn't get saved to the database.
We would still like to see if we can help you in more detail. If you send an email to [email protected] with these details, our integration manager can possibly help resolve this.

@woutse
Copy link
Contributor

woutse commented Mar 11, 2024

Thanks again for your message. Though it should work properly, also in Firefox, we can see how a password field might not the best solution for not showing the API Token. Next release will contain an update for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants