Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verb.geom.NurbsCurve.byPoints chokes on consecutive duplicate points #46

Open
dantaub opened this issue Jan 8, 2020 · 0 comments
Open

Comments

@dantaub
Copy link

dantaub commented Jan 8, 2020

Minimal failing example -- run:

verb.geom.NurbsCurve.byPoints([[0,0,0],[0,0,0],[1,1,1]], 1);

The call does not have any errors, but the resulting curve's control point x,y, and z coordinates come out as NaN -- the NaNs are set inside basisFunctionsGivenKnotSpanIndex

If this result is expected from the algorithm, perhaps validating or sanitizing the input on byPoints would be advisable. Alternately, could document input requirements on this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant