From 70252b61b88c29a18342206f647a0f0322a6576f Mon Sep 17 00:00:00 2001 From: Paul Colby Date: Wed, 13 Mar 2024 08:37:26 +1100 Subject: [PATCH] Downgrade to MSVC 14.29 for Qt5 on Windows Since MSVC 14.37 has been removed from the GitHub hosted runner image (win22 20240304.2.1), and 14.29 is the next most-recent MSVC version available (on the GitHub hosted runner image). Squashed commit of the following: commit fd7998a3786c73a4932b5f88b09eb1624515a2ac Author: Paul Colby Date: Wed Mar 13 08:36:04 2024 +1100 Restore the Linux and macOS builds commit bd8498682ab35c2b97f10519e1c2aba15c1a2ab9 Author: Paul Colby Date: Wed Mar 13 08:11:28 2024 +1100 Use the latest MSVS earlier than 14.38 for Qt5 Because MSVC 14.38 has many issues with Qt5, and 14.29 is now the next-latest MSVC on GitHub hosted runners (win22 20240304.2.1). https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md commit eecde34f39d3d710a84949aabecc3514b69f58cf Author: Paul Colby Date: Wed Mar 13 08:01:12 2024 +1100 Try the default MSVC for Qt5 Since MSVC 14.37 was removed from the GitHub hosted runner in win22 version 20240304.2.1. See https://github.com/actions/runner-images/commit/3d6eedc86d7bffdcd0a31cad8d8a6677e7f2402e It this doesn't work (probably won't) I'll try pinning an earlier MSVC version instead. --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index b24556e98..0828577a6 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -365,7 +365,7 @@ jobs: uses: ilammy/msvc-dev-cmd@v1 with: arch: ${{ matrix.msvcArch }} - toolset: ${{ startsWith(matrix.qt, '5') && '14.37' || '' }} # MSVC 14.38+ has many deprecation issues with Qt5. + toolset: ${{ startsWith(matrix.qt, '5') && '14.29' || '' }} # MSVC 14.38+ has many deprecation issues with Qt5. - name: Build env: PROJECT_BUILD_ID: ${{ github.run_number }}.win.${{ matrix.arch }}.${{ matrix.tool }}.qt-${{ matrix.qt }}