From bd8498682ab35c2b97f10519e1c2aba15c1a2ab9 Mon Sep 17 00:00:00 2001 From: Paul Colby Date: Wed, 13 Mar 2024 08:11:28 +1100 Subject: [PATCH] Use the latest MSVS earlier than 14.38 for Qt5 Because MSVC 14.38 has many issues with Qt5, and 14.29 is now the next-latest MSVC on GitHub hosted runners (win22 20240304.2.1). https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 20d28bf9e..1dfe512c2 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -367,7 +367,7 @@ jobs: uses: ilammy/msvc-dev-cmd@v1 with: arch: ${{ matrix.msvcArch }} - #toolset: ${{ startsWith(matrix.qt, '5') && '14.37' || '' }} # MSVC 14.38+ has many deprecation issues with Qt5. + toolset: ${{ startsWith(matrix.qt, '5') && '14.29' || '' }} # MSVC 14.38+ has many deprecation issues with Qt5. - name: Build env: PROJECT_BUILD_ID: ${{ github.run_number }}.win.${{ matrix.arch }}.${{ matrix.tool }}.qt-${{ matrix.qt }}