-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mkv] How to obtain InfoElement::title
(mkv segment title)?
#273
Comments
Hey thanks for the report. I do find it a bit odd how ffmpeg approaches the title tag, but regardless In Symphonia, it seems the title from InfoElement is not properly used, removing #[allow(dead_code)] from https://github.com/pdeljanov/Symphonia/blob/master/symphonia-format-mkv/src/segment.rs#L272 reveals as much. Even though it seems in the realm of MKV metadata usually only refers to the TagsElement, i would argue this title from the InfoElement could also be considered metadata, so we can store it in the metadata structure. I think this would automatically prioritize the title of the TagsElement since it shows up later in the file and would probably overwrite the title entry by InfoElement, same behavior as ffmpeg. Do you think this is a good way to approach it @pdeljanov ? |
The title provided in the I don't really like the idea of overwriting one title with the other, so here are two possible solutions:
I'm leaning towards 2 because it's easier for the end-user, but 1 has some perks too (the end-user doesn't need to look for two different tag names). |
i am personally fine with either way, as long as it is available as a Metadata tag in some way (and not some out-of-the-way function) and is documented what the difference with the normal |
Yeah, it'd be a bespoke tag for MKV. We can document it in the @dedobbin, any thoughts? |
@pdeljanov Sorry for late response. Holiday happened haha. Hmm yeah i think solution 1 is the cleanest. Solution 2 was also something i had in mind because it's simpler but feels bit arbitrary to map it to a specific key for Symphonia. Yeah my vote goes to solution 1. |
Currently in symphonia 0.5.4 there does not seem to be a way to obtain mkv's
InfoElement
'stitle
(ie the title that is directly stored in the segment, and not as a metadata element), or is there some way that i didnt find?ffmpeg for example treats both the same and prints the element's title as a metadata title (unless there is also a metadata title)
some outputs:
if the
TITLE
metadata is set, symphonia finds it:and if both are set (on segment and metadata), then ffmpeg prefers the metadata tag and symphonia also shows the metadata tag
also good to know is that if the metadata title is set, ffmpeg on convert will write that as the segment title (and output no metadata title, maybe unless explicitly told to also write the metadata tag)
The text was updated successfully, but these errors were encountered: