Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jamaica has number 1658 assigned #10

Open
commenthol opened this issue Sep 1, 2020 · 3 comments
Open

Jamaica has number 1658 assigned #10

commenthol opened this issue Sep 1, 2020 · 3 comments

Comments

@commenthol
Copy link
Contributor

According to https://en.wikipedia.org/wiki/List_of_country_calling_codes Jamaica has number 1658 assigned.
This is currently missing in the module.
@pdeschen
Copy link
Owner

pdeschen commented Sep 2, 2020

You can go ahead and provide a PR for this

commenthol added a commit to commenthol/e164.js that referenced this issue Sep 2, 2020
@commenthol
fix(pdeschen#10): 1685 Jamaica
299827b
@commenthol commenthol mentioned this issue Sep 2, 2020
Merged
pdeschen pushed a commit that referenced this issue Sep 2, 2020
@commenthol @pdeschen
fix(#10): 1685 Jamaica
6ec11f7
@pdeschen
Copy link
Owner

pdeschen commented Sep 2, 2020

I’ll publish a new release tomorrow

@commenthol
Copy link
Contributor Author

Hi @pdeschen, Would you please consider publishing the update? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdeschen @commenthol