Fix clang build

peadar · Sep 11, 2023 · dcc8ff9 · dcc8ff9
1 parent e8079e2
commit dcc8ff9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -44,7 +44,7 @@ message(STATUS "Version: ${VERSION_TAG}")
 add_definitions("-DVERSION=${VERSION_TAG}")
 
 set(CMAKE_CXX_STANDARD 17)
-add_definitions("-std=c++17") # the above does not work for clang.
+set(CMAKE_CXX_EXTENSIONS ON)
 
 add_definitions("-Wall -Wextra -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE")
 # Adding frame pointers makes things easy to run performance measurements with,

diff --git a/dump.cc b/dump.cc
@@ -20,7 +20,6 @@
 #endif
 
 using namespace pstack;
-namespace {
 struct DumpCFAInsns {
     Elf::Off start;
     Elf::Off end;
@@ -207,7 +206,6 @@ dumpCFAInsn(std::ostream &os, Dwarf::DWARFReader *r)
             throw (Exception() << "unknown CFA op " << std::hex << int(op)) << std::dec;
     }
 }
-}
 
 template <typename C>
 static std::ostream &

diff --git a/libpstack/proc.h b/libpstack/proc.h
@@ -134,7 +134,8 @@ class StackFrame {
     UnwindMechanism mechanism;
     bool isSignalTrampoline;
     StackFrame(UnwindMechanism mechanism, const Elf::CoreRegisters &regs);
-    StackFrame &operator = (const StackFrame &) = delete;
+    StackFrame &operator = (const StackFrame &) = default;
+    StackFrame(const StackFrame &) = default;
     std::optional<Elf::CoreRegisters> unwind(Process &);
     void setCoreRegs(const Elf::CoreRegisters &);
     void getCoreRegs(Elf::CoreRegisters &) const;
@@ -299,7 +300,7 @@ class SelfProcess : public Process {
     virtual Reader::csptr getAUXV() const override;
     virtual pid_t getPID() const override;
 protected:
-    virtual Elf::Addr findRDebugAddr();
+    virtual Elf::Addr findRDebugAddr() override;
     bool loadSharedObjectsFromFileNote() override;
     std::vector<AddressRange> addressSpace() const override;
 };