forked from dftbplus/skpar
-
Notifications
You must be signed in to change notification settings - Fork 0
/
aradi.notes.txt
83 lines (49 loc) · 2.47 KB
/
aradi.notes.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
* General
√ * Input files contain more than 100 characters per line: shrunk
√ * I would not allow for untagged module imports. We should rather allow for
module renaming on import or importing specific entries from the module:
usermodules:
- skpar.dftbutils.taskdict
- [skpar.dftbutils.taskdict, td]
- [skpar.dftbutils.taskdict, [get_evol, set_whatever]]
Implemented
√ * Name skpar.dftbutils.taskdict is way too long! Why not just skpar.dftbutils?
Implemented
√ * examples/MoS2-repfit/skpar.in.yaml
√ * Without tagimport: how do you know where to get 'get_evol' from?: Gone
* skpar/core/database.py
√ * Do you want to export update()?: not used on own currently
√ * What do we need the Query object for?: used in objectives and .core.plot
* skpar/core/evaluate.py
√ * kwargs is never used in Evaluator(): removed
√ * utopia?: desirable point, which may or may not be within achievable space
√ * Are all class attributes public? Probably don't need to be,
and will be refactored when style and test-coverage for the module are
worked on; Currently the code is not very neat, and linter complains about
too many attributes (Evaluate) and call parameters (__init__).
* skpar/core/test.py
√ * Why is this checked in?: removed
* skpar/core/usertasks.py
√ * ~/.local/share/skpar is a somewhat unfortunate choice. Also users should not
put their own module into the skpar source folder! They will hopefully
obtain skpar via pip and should not meddle with its folders themselves.:
Not used any more
√ * I am not sure, whether trying to look up the file is a good idea at
all. (What about mypackage.subpackage.module.) Why not just simply try to
import the module?
Not done any more
* bin/dftbutils
√ * Calling without argument fails: fixed
* Testing
√ * resulst in 3 failing tests: not if run within the tests directory
----- Additional notes from conversation:
√ * Database -- use or remove: use
* Execute task
√ - re-think the useage of kwargs[-1]; alternative is explicit: options={}: keep
as is for the moment
√ - refactor to use popen and ensure continuous output: using subprocess.call()
is sufficient
* Testing executables -- refactor binaries to only import parsers; then call
the 'main' with options as though these have been parsed from the command
line.: work on this on a separate branch (test-coverage)
√ remove function definitions inside functions