-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect timezone conversion #12
Comments
I have the issue. I'm in the UK and all meets are an extr ahour away accoring to the plugin. This is largely becuase the US and UK are now closer by an extra hour (later this year we'll been future away by an extra hour). FWIW. These two times of year are chaos for transalatlatic time related stuff and such an annoying thing to code around. |
I am having this same problem. :) It is good to know others share the frustration! |
I also got the same problem here. I got an offset of 1 hour. Currently it seems that the plugin does not use the correct offset if daylight saving is active. Currently I am in Germany/Berlin timezone with daylight saving on (+02:00). Here is a sample start of my iCal: |
same here, but we have not changed to winter time yet, neither has anybody else. So I guess it doesn't work in summer time? |
Maybe @pedrofuentes can chime in? Probably the same issue as #1. I see the timezone is being converted / checked here: https://github.com/pedrofuentes/stream-deck-ical/blob/a596732a6e6bed0669a83dc2b3bd77a9de5cc264/src/js/lib/ical.js#L158C1-L158C78, specifically it is this line here: https://github.com/pedrofuentes/stream-deck-ical/blob/a596732a6e6bed0669a83dc2b3bd77a9de5cc264/src/js/lib/ical.js#L162C43-L162C43 that does the wrong conversion. I have the same problem: Computer time zone as well as the ICAL are in the same time zone (W. Europe Standard Time), appointment e.g. (for an appointment from 13:00 - 13:30):
But it is displayed as +1 hour in the future (14:00 - 14:30). |
Actually #1 (comment) is already the solution (from 2021). In my case Outlook/Exchange saves the timezone as Windows just as Outlook/Exchange does not show this special summertime though, it just implies that we know it currently is summer time in some parts of the world. It always keeps the base time zone (WEDT/CET). If you are on Windows and in a region affected by summertime, you can check yourself looking into your Windows time zone settings - it shows "UTC+1" which is wrong, since it currently would be "UTC+2" in the summer time - but it adjusts the time zone automagically for summer. Outlook/Exchange does tell us in the beginning of the iCal file though:
It tells us exactly when daylight time (summer time) starts and ends (see Unfortunately the used library (as explained in #1) doesn't currently use this timezone ( |
The plugin appears to ignore the timezone of the calendar user and calculates time until meeting as if the meeting time were local. I've included the headers from my .ical, and the beginning of a
VEVENT
I've tried building using the most recent
timezone.js
from the author (along with a version which has an open PR on that repo), along with a current open PR and the problem still persists. Any ideas here?I recall using this plugin successfully, but that was with an organization whose calendar was default to GMT/Zulu. The current organization I work for has their calendar default to PST (which is pretty obvious in the above ical).
The text was updated successfully, but these errors were encountered: