[Bug Report]: Quantum Crafter not consuming durability from items during crafting operations, not correctly using substitutions for crafting patterns with substitutions enabled, and deleting items

[tshepherd3435]

Minecraft Version

1.20.1

Mod Version

1.0.13-1.20.1

Did you test the latest version?

Yes

Severity

Odd Results

NeoForge Version

forge-47.3.11

Describe the Issue

I have a Quantum Crafter with patterns set to upgrade Mystical Agriculture Inferium Essence through all tiers, using tiered crystals with limited durability. The patterns all have "substitutions enabled" active. When completing a single crafting operation, say 4x Inferium Essence -> 1x Prudentium Essence, no durability is consumed from the relevant infusion crystal. Similar behaviour is observed with GregTech items with recipes which should consume durability from tools; no durability is used.

The Quantum Crafter does not perform crafts involving ingredients with durability if the ingredient does not have exactly the same NBT data as in the pattern, even if the pattern is set to enable substitutions. Notably, regular AE2 autocrafting will reuse a tool or MA crystal when NBT doesn't exactly match.

Some items which are not consumed in a crafting operation get deleted when used by the Quantum Crafter, namely the Master Infusion Crystal from Mystical Agriculture.

Reproduction Steps

Create a barebones ME system with only power, a Quantum Crafter, a Pattern Encoding Terminal and some storage. Create a pattern for a recipe where at least one ingredient is not consumed, but loses durability (for example, GregTech plates or rods using tools, or Mystical Agriculture essence upgrading). Make sure the pattern has "substitutions enabled". Place pattern into Quantum Crafter and enable it. Open the terminal and insert the ingredients. The craft will complete, but the ingredient with durability will have its durability unchanged, while performing this craft manually or through standard AE2 autocrafting will see the durability decrease.

Insert another set of ingredients, but make sure the durability item doesn't exactly match the pattern. For example, if the pattern calls for a fresh GregTech iron hammer, insert a damaged iron hammer. This time, the craft will not happen. However, placing this pattern in a standard AE2 Pattern Provider and requesting the craft through basic AE2 autocrafting will work.

In the same system, create a pattern for a recipe where at least one ingredient is not consumed (for example, Mystical Agriculture essence upgrading using the Master Infusion Crystal specifically, or the CookingForBlockheads Sink recipe, which requires one water bucket and returns one empty bucket). Place pattern into Quantum Crafter and enable it, then insert ingredients into ME system. The craft completes, but the non-consumed ingredient vanishes from the system entirely.

Screenshots and Videos

No response

Additional Context

No response

Crash log

https://mclo.gs/mtCu2Pz

[pedroksl]

The first two issues are expected given the implementation, because I don't actually "perform" the craft, I just extract inputs from the system and return outputs. That said, it should be fixed any way. The third one is rather odd, because I tested it quite a lot to make sure it was ok in 1.21.1. And it does work in all packs I've played so far. However the 1.20.1 port wasn't tested nearly as much as the original and this wasn't tested at all.

Was this on a pack or on a minimal setup instance with just the relevant mods present?

[tshepherd3435]

It's in All the Mods 9 version 1.0.2 (one version behind current), but with AdvancedAE manually updated to version 1.0.13; none of the other mods are updated in the newest version of ATM9. That is, all relevant mods are on their newest versions even if the pack overall isn't.

Haven't tested a minimal setup but can if you need me to.

[pedroksl]

It would be nice if you could test just the last bug while I work on other things. But from the looks of it, seems like a porting issue.
The first two are definitely bugs and should be fixed as soon as I find time to work on it.