Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pega-tomcat-keystore-secret.yaml still generated if external secret is provided #812

Open
rob8714 opened this issue Sep 27, 2024 · 0 comments

Comments

@rob8714
Copy link

rob8714 commented Sep 27, 2024

Describe the bug
The pega-tomcat-keystore-secret.yaml is producing output even if an external secret is provided.

To Reproduce
Set the following for the tiers in the values file and generate the helm chart:

service:
  tls:
    enabled: true
    external_secret_names: ["test"]

Expected behavior
When external_secret_names is not empty, the pega-tomcat-keystore-secret.yaml content should not be generated.

Chart version
v3.24.3

Additional context
Potentially this was broken with 7d03c0f. With this commit there was a change in name from external_secret_name to external_secret_names. In pega-tomcat-keystore-secret.yaml the condition is:

{{ if not (($dep.service).tls).external_secret_name }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant