Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DayZ] Bug Fixing & Cleanup #46

Merged
merged 3 commits into from
Sep 30, 2024
Merged

[DayZ] Bug Fixing & Cleanup #46

merged 3 commits into from
Sep 30, 2024

Conversation

redthirten
Copy link
Contributor

@redthirten redthirten commented Jul 5, 2024

Description

Egg:

  • Fixed mission persistence and mission parameters (like loot tables, etc.) being broken due to missing vanilla mission files in certain scenarios (ie. Steam account does not own the DayZ game).
  • Fixed bugs that prevented the server from starting due to a missing hostname variable in 'serverDZ.cfg'.
  • Improved the installation script to better accommodate Steam users with Steam Guard enabled and check for missing required files.
  • Changed the installation script to not overwrite 'beserver_x64.cfg` upon reinstallation if it already exists.
  • Changed the default Steam Query Port to be correct.

README:

  • Added @shaynendradika as a contributor.
  • Fixed/Improved "Server Ports" section.
  • Elaborated on the differences that game ownership makes in the "Installation/System Requirements" section.
  • Updated the "Running With Steam Guard Enabled" section.
  • Fixed typo.

Resolves #39 Edit: Issue author still reports issues after applying the changes in this PR.

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
  • You verify that the start command applied does not use a shell script
  • The egg was exported from the panel

Added default serverDZ.cfg file for install script if it needs to be downloaded.
Egg:
- Fixed mission persistence and mission parameters (like loot tables, etc.) being broken due to missing vanilla mission files in certain scenarios (ie. Steam account does not own the DayZ game).
- Fixed bugs that prevented the server from starting due to a missing `hostname` variable in 'serverDZ.cfg'.
- Improved the installation script to better accommodate Steam users with Steam Guard enabled and check for missing required files.
- Changed the installation script to not overwrite 'beserver_x64.cfg` upon reinstallation if it already exists.
- Changed the default Steam Query Port to be correct.

README:
- Added shaynendradika as a contributor.
- Fixed/Improved "Server Ports" section.
- Elaborated on the differences that game ownership makes in the "Installation/System Requirements" section.
- Updated the "Running With Steam Guard Enabled" section.
- Fixed typo.
@redthirten redthirten requested a review from QuintenQVD0 July 5, 2024 01:25
@Tetra2k
Copy link

Tetra2k commented Jul 7, 2024

I tested it, but I still have the same problem.

`env` is now `server.environment` in Pelican panel
Copy link

@PsychicRoot PsychicRoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@redthirten
Copy link
Contributor Author

redthirten commented Sep 30, 2024

To prevent this PR from going stale, and because these fixes are still generally good overall & finally have been tested and approved by someone other than myself, I'm going to go ahead and merge it. However, because it still cannot be confirmed to fix #39, I will remove the link to this PR that would close that issue (leaving it open to be fixed in the future).

Edit: Apparently Github is dumb and doesn't allow unlinking an Issue. I'll just merge and reopen the Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DayZ persistence does not work
3 participants