Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross origin return #5

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Cross origin return #5

merged 2 commits into from
Sep 11, 2023

Conversation

colingm
Copy link
Collaborator

@colingm colingm commented Sep 11, 2023

No description provided.

colingm and others added 2 commits August 30, 2023 14:08
If we have cross origin record turned on but we are in a child
frame that has the same origin as its parent we end up in sort
of an inefficient state. We will start the recording, record
mutations, but then never actually emit them anywhere since
inEmittingFrame and passEmitsToParent are both false. This
is a waste of resources and we might as well just never start
the recording.
@colingm colingm merged commit 04fa0dd into agent-main Sep 11, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant