Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itertracks() doesn't work properly in 0.1.1 #10

Open
Purfview opened this issue Nov 14, 2024 · 4 comments
Open

itertracks() doesn't work properly in 0.1.1 #10

Purfview opened this issue Nov 14, 2024 · 4 comments

Comments

@Purfview
Copy link

Purfview commented Nov 14, 2024

itertracks() doesn't work properly in 0.1.1. problems:

  1. Hyperparameters onset/offset doesn't work properly, for example in the output there are segments shorter than "onset".
  2. Looks like segments in time skew to front.
  3. Segments overlap.

Audio to test:
audio.mka_dump.zip

UPDATE:
I thought that onset/offset corresponds to "min_duration_on"/"min_duration_off".
onset/offset shouldn't be touched for pyannote/segmentation-3
"min_duration_on"/"min_duration_off" could be set in some very first version of pyannote-onnx , can you add them back?

@pengzhendong
Copy link
Owner

You could try sherpa-onnx with pyannote-audio.

@Purfview
Copy link
Author

You could try sherpa-onnx with pyannote-audio.

I tried it but it doesn't have "min_duration_on"/"min_duration_off" implemented too, btw, it works very well, almost same output as original pyannote segmentation.
Another thing it's slow, ~same speed as pyannote's torch version, when your repo is ~4 times faster.

@pengzhendong
Copy link
Owner

pengzhendong commented Nov 15, 2024

OK, I will try to add "min_duration_on"/"min_duration_off".

This repo is faster because I use a large step = 5s (pyannote's is step = 1s, you could change it):

step = self.duration // 2

@Purfview
Copy link
Author

step = self.duration // 2

Tested step = self.duration // 10 it got slower only ~10%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants