made pennkeys lowercase and changed test case #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clue88
requested changes
Oct 24, 2024
Would also be great to add 1-2 sentences on why this is needed! It's helpful to have more documentation on why we're making changes. |
|
Do you want me to add comments in the code or in some sort of documentation? |
Just within the PR itself would be sufficient. Something like this. |
shiva-menta
requested changes
Nov 13, 2024
backend/courses/views.py
Outdated
| username = request.data.get("pennkey") | ||
| if not username: | ||
| res["message"] = "User not found" | ||
| return Response(res, status=status.HTTP_404_NOT_FOUND) |
There was a problem hiding this comment.
Can make this more succinct and use raise Http404("User not found.").
backend/courses/views.py
Outdated
| username = request.data.get("pennkey") | ||
| if not username: | ||
| res["message"] = "User not found." | ||
| return Response(res, status=status.HTTP_404_NOT_FOUND) |
shiva-menta
approved these changes
Nov 14, 2024
luke-rt
pushed a commit
that referenced
this pull request
Feb 13, 2025
* made pennkeys lowercase and changed test case
* Added handling for edge cases
* fixed whitespace
* Fixed more whitespace. All stylizing
* changed the response schema
* made http404 message more succinct
* imports in alphabetical order I think
* removed one res = {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it so when people send friend requests on penn courses, it changes the username to all lowercase so that when people add friends and accidentally capitalize the first letter it still is able to find the friend they are looking for.