Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pindexer: add override for indexing asset id #4920

Open
conorsch opened this issue Nov 13, 2024 · 0 comments · May be fixed by #4936
Open

pindexer: add override for indexing asset id #4920

conorsch opened this issue Nov 13, 2024 · 0 comments · May be fixed by #4936
Labels
needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@conorsch
Copy link
Contributor

Since #4914, pindexer contains a hardcoded asset id that refers to USDC on the penumbra-1 chain. Having chain-specific logic hardcoded is undesirable, so let's preserve that as a sane default, but make it overrideable via a CLI flag.

The same issue is also present for the insights dashboard ; maybe we should add a command line argument to override USDC? (in both cases)

Originally posted by @cronokirby in #4917 (comment)
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Nov 13, 2024
@conorsch conorsch mentioned this issue Nov 13, 2024
Merged
2 tasks
@cronokirby cronokirby linked a pull request Nov 19, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-refinement unclear, incomplete, or stub issue that needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pindexer: implement override for hardcoded values in app views penumbra-zone/penumbra
1 participant
@conorsch