-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TransactionView::summary()
method
#4939
Labels
needs-refinement
unclear, incomplete, or stub issue that needs work
Comments
step towards penumbra-zone/web#1394 cc @grod220 |
2 tasks
erwanor
added a commit
that referenced
this issue
Dec 13, 2024
## Describe your changes References #4939 ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: --------- Signed-off-by: Erwan Or <[email protected]> Co-authored-by: Lucas Meier <[email protected]> Co-authored-by: Erwan Or <[email protected]> Co-authored-by: Erwan Or <[email protected]>
erwanor
added a commit
that referenced
this issue
Dec 13, 2024
References #4939 - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: --------- Signed-off-by: Erwan Or <[email protected]> Co-authored-by: Lucas Meier <[email protected]> Co-authored-by: Erwan Or <[email protected]> Co-authored-by: Erwan Or <[email protected]>
This was done for |
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
There are many applications where it would be useful to display a summary of a transaction's effects on the balances of various accounts, both pre- and post-confirmation:
This logic should be implemented once, in the Rust code, so that it can be standardized across the Penumbra ecosystem.
Describe the solution you'd like
The
Balance
struct improperly has a derived Serde representation. This is a bug and a violation of our serialization policy. Verify that this was never used. Define a Protobuf message for theBalance
struct and use that as the serialization format.Define a new Protobuf message and corresponding domain type,
penumbra.core.transaction.v1.TransactionSummary
, something like (sketch):TransactionView::summary(&self) -> TransactionSummary
that produces aTransactionSummary
, iterating through each visible action and collecting the effects of the transaction. This should preserve the info available in theAddressView
s about the meaning of the addresses.The text was updated successfully, but these errors were encountered: