Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for TransactionPlannerRequest #410

Closed
Tracked by #333
grod220 opened this issue Jan 25, 2024 · 1 comment · Fixed by #690
Closed
Tracked by #333

Add tests for TransactionPlannerRequest #410

grod220 opened this issue Jan 25, 2024 · 1 comment · Fixed by #690
Assignees
Labels
testing Related to writing tests

Comments

@grod220
Copy link
Collaborator

grod220 commented Jan 25, 2024

No description provided.

@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Jan 25, 2024
@grod220 grod220 added the testing Related to writing tests label Jan 25, 2024
@Valentine1898
Copy link
Contributor

If we pick up #609 in the near future, it makes sense to hold off on these tests.
At the current moment I will have to mock all wasm planner calls, and such tests will not be very useful

@Valentine1898 Valentine1898 linked a pull request Mar 6, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to writing tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants