move amendments and imports under project_modifiers

[stolarczyk]

amendments and imports to fall under project_modifiers ?

the it'd be:

project_modifiers:
  amend: ...
  imply: ...
  import: ...
sample_modifiers:
  append: ...
  imply: ...
  derive: ...
  ...

Originally posted by @nsheff in #342 (comment)

[nsheff]

Arguments for:

• parallel structure with sample_modifiers
• more clear that amendments and imports modify the project
• we would be better prepared for future modifier types, such as proposed in implement project_modifiers.imply #342

Arguments against:

• adds another hierarchical layer for imports/amendments
• imports somehow feels like it belongs at the top level... (just a familiarity thing?)
• amendments are different than all other modifiers in that they don't run automatically (but I suppose each modifier has its own idiosyncrasies)

Overall I think it makes sense to use project_modifiers as proposed. I view the parallel structure as a substantial benefit, and the semantic clarity of what amend and import does also. I would like to hear any feedback from @johanneskoester, @jpsmith5, @afrendeiro, @vreuter if you care to chime in.

[afrendeiro]

Slight preference for the more hierarchical project_modifiers.

[vreuter]

So currently those exist as project-level keys, right? And functionally, "amendments" is basically like what was "subprojects?"

[vreuter]

So currently those exist as project-level keys, right? And functionally, "amendments" is basically like what was "subprojects?"

If that understanding is roughly true, I agree w/ @afrendeiro . My preference isn't strong either, but I like the parallel structure that's gained by making it hierarchical rather than a "level up," and I think it fits nicely w/ the Python tenet of explicit-over-implicit.

[stolarczyk]

So currently those exist as project-level keys, right?

yes

And functionally, "amendments" is basically like what was "subprojects?"

Yes, except for the fact that you can activate multiple at once

[vreuter]

Yes, except for the fact that you can activate multiple at once

Nice! 🔥