Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vuexOidcSignOut to be exposed #126

Closed
apavelm opened this issue Sep 3, 2020 · 2 comments
Closed

vuexOidcSignOut to be exposed #126

apavelm opened this issue Sep 3, 2020 · 2 comments

Comments

@apavelm
Copy link

apavelm commented Sep 3, 2020

This is discussable. And could be considered as a feature request.

Normally, page for silent token-renewal is a lightweight (I believe this is good) and not connected to main Vue application.
In other words it looks like
image

For some use-cases user needs to do a signout when catching an error.
Maybe this is a good point to expose a method for a signout (or redirect to logout page)?

@perarnborg
Copy link
Owner

It could possibly be a good idea to expose the signout triggers, although I am not certain and in this case it would not really work.

First of all as far as I can see you cannot count on the fact that siginSilentCallback (that ´vuexProccessSilentSigninCallback´ returns) gets rejected when the signin fails – see comment in #125 .

And secondly this code runs in an iframe, so this is not where you would want to redirect the user to the provider, you want to do that in the main window. Posting an event up to the parent window could be an option, but I think a better way forward would be to enable cathing the failed signin inside the vue app, which I hope to do shortly.

@perarnborg
Copy link
Owner

Closing this since it is now possible to catch errors on silent signins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants