We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This line from the middleware makes sure that exceptions are re-raised after counting them:
https://github.com/perdy/starlette-prometheus/blob/master/starlette_prometheus/middleware.py#L57
But the from None part is removing any existing chain from the original exception.
from None
This is really unexpected, since the logging behaviour changes after adding the middleware.
I don't see a reason to suppress the chain, was there a reason at some point ?
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
This line from the middleware makes sure that exceptions are re-raised after counting them:
https://github.com/perdy/starlette-prometheus/blob/master/starlette_prometheus/middleware.py#L57
But the
from None
part is removing any existing chain from the original exception.This is really unexpected, since the logging behaviour changes after adding the middleware.
I don't see a reason to suppress the chain, was there a reason at some point ?
The text was updated successfully, but these errors were encountered: