Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change folder delimiter to semicolons and disallow semicolons from names #439

Open
camdendotlol opened this issue Sep 23, 2022 · 1 comment
Assignees

Comments

@camdendotlol
Copy link

The document folder feature added in #433 uses the acts-as-taggable-on gem, specifically this version: https://www.rubydoc.info/gems/acts-as-taggable-on/4.0.0

acts-as-taggable-on stores the list folder names as a single string with a comma delimiting each name. This means that, currently, if you try to add a folder named Blake, William, it will end up applying two folders, Blake and William to the selected documents.

I discussed this issue with Dino and we agreed on the following solution:

  1. Change the delimiter to ;, which according to the docs is as simple as calling a delimiter method in the acts-as-taggable-on inititializer.
  2. Disallow the semicolon from folder names and display an error if the user tries to add one.
@jamiefolsom
Copy link
Member

We can't change the delimiter application-wide; first step here is to figure out if we can change it for just the folder, and not other tag contexts. @camdendotlol @sarastanton

@jamiefolsom jamiefolsom modified the milestone: Fall 2022 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants