Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iso8601 Ruby date method for authentication token #14

Open
camdendotlol opened this issue Aug 22, 2022 · 1 comment
Open

Use iso8601 Ruby date method for authentication token #14

camdendotlol opened this issue Aug 22, 2022 · 1 comment

Comments

@camdendotlol
Copy link

The authentication controller creates a date string for the token, which the frontend JS parses to determine whether the token is expired.

The format used for the token is parseable in Chrome's JS engine, but not in Firefox. If you replace the strftime method with iso8601, the resulting string will be in a format guaranteed to be parseable in all JS engines.

https://github.com/performant-software/iiif-cloud/blob/master/app/controllers/api/authentication_controller.rb#L27

@camdendotlol
Copy link
Author

This issue also affects Safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant