Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API filters #21

Open
dleadbetter opened this issue Oct 4, 2022 · 1 comment
Open

API filters #21

dleadbetter opened this issue Oct 4, 2022 · 1 comment
Assignees
@dleadbetter

Comments

@dleadbetter
Copy link
Contributor

We should update the /user_defined_fields/user_defined_fields API endpoint to accept parameters to filter by table_name, column_name, data_type, etc.
@camdendotlol
Copy link

camdendotlol commented Oct 5, 2022 •
edited
Loading

Seeing this on NBU.

My fields look like this:
Screen Shot 2022-10-05 at 4 19 13 PM

But all three options appear anywhere UserDefinedFieldsForm is used. For example, the Collection form, which should only show the "Has Camden visited?" field, contains all three:

Screen Shot 2022-10-05 at 4 12 06 PM

It appears that there is no way to pass a table_name filter to UserDefinedFieldsForm, which may be a separate but related bug in @performant-software/user-defined-fields.

@dleadbetter dleadbetter self-assigned this Oct 5, 2022
dleadbetter added a commit that referenced this issue Oct 5, 2022
@dleadbetter
UDF #21 - Adding table_name filter to user_defined_fields_controller
f1686ae
dleadbetter added a commit that referenced this issue Oct 6, 2022
@dleadbetter
UDF #21 - Updating validation to only include fields for the current …
76b5f8b 
…model
dleadbetter added a commit that referenced this issue Oct 6, 2022
@dleadbetter
Merge pull request #22 from performant-software/feature/udf21_table_f…
8e3a6ef 
…ilter

UDF #21 - Table filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dleadbetter dleadbetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dleadbetter @camdendotlol