Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SwiftLint in Continuous Integration - Discussion #803

Closed
mildm8nnered opened this issue Aug 23, 2024 · 1 comment
Closed

Implement SwiftLint in Continuous Integration - Discussion #803

mildm8nnered opened this issue Aug 23, 2024 · 1 comment

Comments

@mildm8nnered
Copy link
Contributor

Opening this as a place to hang discussion.

Makefile entry should be easy enough, perhaps

swiftlint:
        swiftlint --quiet

but SwiftLint will exit with 0 on any successful run, whether violations are detected or not, so possibly we'll want a wrapper script with an exit value

There's also the question of how SwiftLint should be installed/assumptions about paths on the CI machines. For example, homebrew installs SwiftLint at /opt/homebrew/bin/swiftlint, which may (or may not) be on the CI user's path.

See for example, https://github.com/realm/SwiftLint#installation

@ileitch
Copy link
Contributor

ileitch commented Aug 24, 2024

Implemented in #806 using mise.

@ileitch ileitch closed this as completed Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants