-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple clock number from size of history (Max history depth) #37
Comments
The reason to have clock in GuiData is that it provides a lens, so when changed components like the ProbeEdit knows that something has happened. Regarding memory leak, I don't quite follow. |
I mean that keeping an unlimited sized history might not be optimal, as it might cause issues if you for example leave the clock running in the background and forget about it, as it will endlessly grow. |
Indeed, the simulator holds the |
Components (and GUI elements) that holds internal state etc., is responsible for their own history management, essentially triggered by |
Having clock number tied to history causes issues on higher clock numbers, as it is effectively a memory leak. It would be better to keep it separate, and add a limit to how large the history size can grow before it starts discarding the oldest records. I also suggest that instead of
clock
being stored inGuiData
it is instead fetched when needed from the simulator.The text was updated successfully, but these errors were encountered: