Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does the perfect Pull Request look like? #2138

Open
ghost opened this issue Apr 28, 2021 · 1 comment
Open

How does the perfect Pull Request look like? #2138

ghost opened this issue Apr 28, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 28, 2021

Hi @dgarijo and @davidlehn,

I just sent out a Pull Request, and was wondering what the perfect content of the Pull Request would actually be to make your life easy.

For example, I put in a link to the Readme, so you can check that I am actually "allowed" to make that change. The Readme already says that the project name should be in the title of the Pull Request (as far as I understood)....

I found that it's possible to create a template for Pull Requests, maybe that's something for you, too? https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

Best,
Robert

@dgarijo
Copy link
Collaborator

dgarijo commented Apr 29, 2021

@robertgiessmann,
thanks. I think following the instructions we have in the readme should be enough, but having a link to the root readme saves me a couple of clicks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant