Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 version fork and some questions #2

Open
BEEugene opened this issue Aug 28, 2019 · 3 comments
Open

Python 3 version fork and some questions #2

BEEugene opened this issue Aug 28, 2019 · 3 comments

Comments

@BEEugene
Copy link

Hi, again!
First, I've forked the package and made python 3 support.
I am not an experienced user of python and Github, should I do some commits or leave the fork to leave by itself?

The second problem is that with the following project structure:

-project:
--fold0
---subfolder
----more subfolders
---subfold2
--fold1
--fold2

the public-release export only modules from fold0, others are not exported.
For example, I've
import fold0.subfolder... module which is imported in subfold2.
The public-release exports this successfully and rewrites as
from helpers import ...
but the other imports from fold1 and fold1 stays the same as
from fold1... import ...
Is this a regular thing? (or maybe I broke smth:))

@BEEugene
Copy link
Author

Found an answer to the second problem.
I didn't have the init.py file in fold1, so the script didn't saw them.
For the fold2 I've changed a pipeline in a "project" scope.

@petered
Copy link
Owner

petered commented Nov 23, 2023

Nice, apologies for the 4-year-late reply. Should I merge your fork? Is it good?

@BEEugene
Copy link
Author

Ok. Well, not sure about that, didn't use it for long time, but it definitely worked somehow and helped me, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants