Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #9 #10

Closed
galund opened this issue Feb 3, 2012 · 1 comment
Closed

Issue #9 #10

galund opened this issue Feb 3, 2012 · 1 comment

Comments

@galund
Copy link
Contributor

galund commented Feb 3, 2012

This is my fix for Issue #9, apologies if something is wrong I never used github before :-)

#9

@petewarden
Copy link
Owner

Thanks for that, I've merged it in. Funnily enough I noticed something
similar performance-wise when I reused some of the code in another project,
and ported it over to the prototype method, but didn't backport the changes:
https://github.com/petewarden/flxjs/blob/master/flxjs.js

I really appreciate the patch, and great to hear you've been getting use
out of the component!

cheers,
Pete

On Fri, Feb 3, 2012 at 9:50 AM, galund-mintel <
[email protected]

wrote:

This is my fix for Issue #9, apologies if something is wrong I never used
github before :-)

#9

You can merge this Pull Request by running:

git pull https://github.com/galund-mintel/openheatmap master

Or you can view, comment on it, or merge it online at:

#10

-- Commit Summary --

  • Performance fixes: create class methods using Class.prototype, rather
    than

-- File Changes --

M static/scripts/jquery.openheatmap.js (536)

-- Patch Links --

https://github.com/petewarden/openheatmap/pull/10.patch
https://github.com/petewarden/openheatmap/pull/10.diff


Reply to this email directly or view it on GitHub:
#10

petewarden added a commit that referenced this issue Oct 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants