Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library No Longer Functions: example no longer returns results #111

Closed
kanjieater opened this issue Jan 21, 2024 · 1 comment
Closed

Library No Longer Functions: example no longer returns results #111

kanjieater opened this issue Jan 21, 2024 · 1 comment

Comments

@kanjieater
Copy link

Thanks for the quick release of the 6.4.3 as requested. Unfortunately the reason I'm seeing 0 results wasn't due to that bug, but rather I think the library is no longer functioning as intended. You can see this by running the example code.


var Scraper = require('images-scraper');

const google = new Scraper({
  puppeteer: {
    headless: true,
  },
});

(async () => {
  const results = await google.scrape('banana', 200);
  console.log('results', results);
})();


I've used this library for a few years w/o issue and hope to continue using it. Thanks.

@kanjieater kanjieater changed the title Library example no longer returns results Library No Longer Functions: example no longer returns results Jan 21, 2024
@pevers
Copy link
Owner

pevers commented Jan 22, 2024

Thanks for the quick release of the 6.4.3 as requested. Unfortunately the reason I'm seeing 0 results wasn't due to that bug, but rather I think the library is no longer functioning as intended. You can see this by running the example code.


var Scraper = require('images-scraper');

const google = new Scraper({
  puppeteer: {
    headless: true,
  },
});

(async () => {
  const results = await google.scrape('banana', 200);
  console.log('results', results);
})();

I've used this library for a few years w/o issue and hope to continue using it. Thanks.

A small bug was introduced but already fixed here: #110 . I just shipped this new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants