Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the chord note shapes #26

Open
pganssle opened this issue Nov 26, 2023 · 0 comments
Open

Improvements to the chord note shapes #26

pganssle opened this issue Nov 26, 2023 · 0 comments

Comments

@pganssle
Copy link
Owner

I wanted to get #17 out the door, and the MVP was basically "chord notes with shapes" (I figure that once kids start using it with the shapes, those shapes will end up being locked in, since it will be disruptive to change the shapes on them), but I wasn't able to get the CSS to look quite how I liked. Here is how it looks now:

image

As you can see, the shapes are pretty indistinct for the dark colors. I am also not sure I really want it to be white text on black shapes. I think what we need to do is make the shapes have an outline, but that is surprisingly hard to accomplish with CSS using clip-paths like I'm doing here. Maybe since I'm just clipping the path using some CSS shape or SVG the right thing to do is to move away from clip-path and just make those divs be a shape? Not quite sure how to accomplish that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant