Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compression options during modification? #21

Open
parity3 opened this issue Aug 6, 2023 · 0 comments
Open

compression options during modification? #21

parity3 opened this issue Aug 6, 2023 · 0 comments

Comments

@parity3
Copy link

parity3 commented Aug 6, 2023

It seems like the the fdw will create an uncompressed parquet file when inserting into a created foreign table, which surprised me.

I think it would be great if this library supported snappy, but more ideal: zstd for parquet compression. Was there a reason this was defaulted to uncompressed? I was expecting compression to be an option in the CREATE FOREIGN TABLE statement.

I think this is just a missing statement before arrow's WriteTable call as described in their docs:

// Choose compression
std::shared_ptr<WriterProperties> props =
    WriterProperties::Builder().compression(arrow::Compression::SNAPPY)->build();

Was this left out for a reason? Perhaps it makes build dependencies or licensing harder?

This library is ALMOST there as a missing piece of the puzzle for smooth integration between OLTP and OLAP/warehouse workloads. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant