Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use left shift to NOT Mount/Dismount the rest of the team #5

Open
Phanx opened this issue Dec 5, 2014 · 3 comments
Open

Use left shift to NOT Mount/Dismount the rest of the team #5

Phanx opened this issue Dec 5, 2014 · 3 comments

Comments

@Phanx
Copy link
Member

Phanx commented Dec 5, 2014

(Originally posted by sconley on WoWInterface)

I would like to see the addon changed so that if I'm pressing the left shift key when i dismount or mount, the rest of the team will do nothing.

I've changed this in my copy of Hydra and feel it would be beneficial to others.

@Phanx
Copy link
Member Author

Phanx commented Dec 5, 2014

I'm not opposed to adding a bypass feature, but that specific implementation would be problematic for me, as I already use Shift as a modifier to force dismounting while in the air. I may add a dropdown for selecting a bypass modifier in the future.

@fireymerlin
Copy link

I'm not sure about the dismounting while in the air part. I don't see any code in mount.lua related to that in the areas I modified. I'm sure you know what to add, but here it is anyway in case it would not interfere with using shift (line numbers other than first, assume changes have been made which pushed all lines down):
After line 173, add:
if not IsLeftShiftKeyDown() then
After line 185 add:
end
After line 204 add:
if not IsLeftShiftKeyDown() then
After line 214 add:
end

@Phanx
Copy link
Member Author

Phanx commented Jan 8, 2015

The "use Shift to force dismounting in the air" is not a feature of Hydra. It is a feature of the macro I use for mounting and dismounting -- eg. /dismount [noflying] [mod:shift] -- so that accidentally hitting the button while flying does not dismount me in midair and cause me to plummet to my death.

The code you posted would indeed interfere with the use of the mod:shift conditional in macros.

Adding a modifier key check in Hydra is obviously trivial, I just haven't done it because I'm not wholly convinced it's a useful feature, especially since it would require the addition of more options (to select the modifier key, to choose whether it applies to mounting, dismounting or both, etc) to make it usable with macros. The ticket is still open, which means I haven't decided against it, but it's a very low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants