From 4035e6e1265c06602622a7f6e44edaf0ebaecb24 Mon Sep 17 00:00:00 2001 From: Jeff Thompson <160783290+jthompson-arcus@users.noreply.github.com> Date: Tue, 9 Jul 2024 11:09:12 -0400 Subject: [PATCH 1/3] Correctly parse `riskmetric` dependency assessment --- R/utils_insert_db.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/utils_insert_db.R b/R/utils_insert_db.R index 3b9f9cb1..0c95e09a 100644 --- a/R/utils_insert_db.R +++ b/R/utils_insert_db.R @@ -202,7 +202,7 @@ insert_riskmetric_to_db <- function(pkg_name, pkg_version = "", metric_value <- case_when( "pkg_metric_error" %in% class(riskmetric_assess[[metric$name]][[1]]) ~ "pkg_metric_error", - metric$name == "dependencies" ~ as.character(length(unlist(as.vector(riskmetric_assess[[metric$name]][[1]][1])))), + metric$name == "dependencies" ~ as.character(NROW(riskmetric_assess[[metric$name]][[1]])), metric$name == "reverse_dependencies" ~ as.character(length(as.vector(riskmetric_assess[[metric$name]][[1]]))), metric$is_perc == 1L ~ as.character(round(riskmetric_score[[metric$name]]*100, 2)[[1]]), TRUE ~ as.character(riskmetric_assess[[metric$name]][[1]][1:length(riskmetric_assess[[metric$name]])]) From f46c7035c34820e346b596243143119f1fe80de9 Mon Sep 17 00:00:00 2001 From: Jeff Thompson <160783290+jthompson-arcus@users.noreply.github.com> Date: Tue, 9 Jul 2024 13:33:25 -0400 Subject: [PATCH 2/3] Update NEWS --- NEWS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.md b/NEWS.md index c24df3cf..72307ff7 100644 --- a/NEWS.md +++ b/NEWS.md @@ -2,6 +2,7 @@ * Added navigation controls in Function Explorer tab (#644) * Fixed bug that crashed the Package Dependencies page for pkgs without any dependency info available (#802) +* Fixed bug that incorrectly displayed 0 dependencies as 1 (#805) # riskassessment 3.1.0 From d2c3900f4e31f71735f5beecb6a67ecf76eef693 Mon Sep 17 00:00:00 2001 From: Github Actions Date: Tue, 9 Jul 2024 17:39:05 +0000 Subject: [PATCH 3/3] Re-build manifest file --- manifest.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/manifest.json b/manifest.json index ceee46fc..2e41d979 100644 --- a/manifest.json +++ b/manifest.json @@ -4367,7 +4367,7 @@ "Maintainer": "Kevin Ushey ", "Repository": "RSPM", "Date/Publication": "2024-02-29 01:10:07 UTC", - "Built": "R 4.3.3; ; 2024-07-09 14:01:48 UTC; unix" + "Built": "R 4.3.3; ; 2024-07-09 17:38:19 UTC; unix" } }, "reprex": { @@ -6463,7 +6463,7 @@ "checksum": "97d1232340e04c53088bc8f814133dcd" }, "NEWS.md": { - "checksum": "72bdae63c42eb2750d86e97fc0996a79" + "checksum": "2273640b8da14304bc919f4fc83a58d7" }, "R/app_config.R": { "checksum": "c2b61f270b86b6833f0ee39c44a1a440" @@ -6574,7 +6574,7 @@ "checksum": "6c0e6fb4b3716cdd0c0d2953a1cf4393" }, "R/utils_insert_db.R": { - "checksum": "2c02e4eab4d9262ef8c8e64eb0f1b4f5" + "checksum": "5eaa94311e33014f000eb3cc5aec8282" }, "R/utils_startup.R": { "checksum": "b689ee96f0761480ac65ca22cbbb4980"