Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functionPointerFor:inClass: has unused argument #822

Open
guillep opened this issue Jun 27, 2024 · 0 comments
Open

functionPointerFor:inClass: has unused argument #822

guillep opened this issue Jun 27, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@guillep
Copy link
Member

guillep commented Jun 27, 2024

functionPointerFor:inClass: has several implementations but the argument is not used.
We should refactor the code to remove the extra argument.

functionPointerFor: primIdx inClass: theClass
	"Find an actual function pointer for this primitiveIndex.  This is an
	opportunity to specialise the prim for the relevant class (format for
	example).  Default for now is simply the entry in the base primitiveTable."
	<api>
	<returnTypeC: 'void (*functionPointerForinClass(sqInt primIdx,sqInt theClass))(void)'>
	^primIdx > MaxPrimitiveIndex ifTrue: [0] ifFalse: [primitiveTable at: primIdx]
@guillep guillep added the good first issue Good for newcomers label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant