You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
rig project data-backup names the backup file dev.tgz, and does so every time. This means users are required to manually rename or delete this file, and their first warning is when the data-backup throws a filesystem error on the name collision.
Label: HELP WANTED
This issue is a great opportunity to learn Golang, the contribution workflow of rig, and incidentally improve rig!
Label: QUESTION
This issue has the question label, meaning before we lay code we should have confirmation on the approach and remove the label. If you want to start on this while it's a question, think through this issue summary, consider the user impact (and the amount of time you have to explore a solution) and post your thoughts!
Solutions
Solution A
If rig data-backup detects dev.tgz already exists, roll that file to include the creation date of the file or a suffix digit, and set an info log to notify the user.
Solution B
Create an ~/.outrigger/backups directory.
Always include the backup datetime in the filename, e.g., ~/.outrigger/backups/{machine}-20171115171530.tgz
Create a symlink from dev.tgz to the most recent backup.
Solution C
???
Confirmation
Compilation
Use docker-compose run --rm compile to confirm your code compiles.
You can use the binary resulting from the compilation step (located in ./build/darwin/rig).
Functional Testing
Create a backup.
Restore the backup.
Create a backup.
Restore the backup.
Prepare for Pull Request
Use docker-compose run --rm lint to apply the full suite of static analysis tools. If there is a failure, you aren't done yet!
Bonus Round
Prompt the user when there are more than 3 backups so they realize they may want to clean up.
The text was updated successfully, but these errors were encountered:
grayside
changed the title
Identify and execute solution for data-backup filename collissions
Identify and execute solution for data-backup filename collisions
Nov 16, 2017
Problem
rig project data-backup
names the backup file dev.tgz, and does so every time. This means users are required to manually rename or delete this file, and their first warning is when the data-backup throws a filesystem error on the name collision.Solutions
Solution A
If rig data-backup detects dev.tgz already exists, roll that file to include the creation date of the file or a suffix digit, and set an info log to notify the user.
Solution B
~/.outrigger/backups/{machine}-20171115171530.tgz
Solution C
???
Confirmation
Compilation
Use
docker-compose run --rm compile
to confirm your code compiles.You can use the binary resulting from the compilation step (located in ./build/darwin/rig).
Functional Testing
Prepare for Pull Request
Use
docker-compose run --rm lint
to apply the full suite of static analysis tools. If there is a failure, you aren't done yet!Bonus Round
Prompt the user when there are more than 3 backups so they realize they may want to clean up.
The text was updated successfully, but these errors were encountered: