Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune down ubiquity of too-many-steps warning in rig project scripts #90

Open
grayside opened this issue Oct 17, 2017 · 3 comments
Open
Labels

Comments

@grayside
Copy link
Contributor

While the aggression of this message it will break eval "$(rig config)". Let's limit this to rig project * and maybe rig doctor.

@grayside grayside added the bug label Oct 17, 2017
@grayside
Copy link
Contributor Author

Note that this will require switching from logging to returning errors, and identifying the correct way for us to differentiate errors so we can designate some as fatal errors and others as warnings.

@grayside grayside modified the milestone: Future Train Oct 25, 2017
@febbraro
Copy link
Member

I think our migration to error/success handling via the CLI framework api means that this should be easier to handle now, correct? It should still only be an reported during project commands, and possibly doctor.

@grayside
Copy link
Contributor Author

ProjectConfig.ValidateProjectScripts still directly logs all it's warnings, and since it is called as part of the Command loading process it continues to be ubiquitous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants