Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Kazari.RARC with Kazari.RARCPacker #13

Open
LordNed opened this issue Jan 18, 2014 · 0 comments
Open

Merge Kazari.RARC with Kazari.RARCPacker #13

LordNed opened this issue Jan 18, 2014 · 0 comments
Assignees

Comments

@LordNed
Copy link
Collaborator

LordNed commented Jan 18, 2014

I'm really digging RARCPacker's clean file structure documentation (of RarcHeader, Node, FileEntry), and I'd like to merge the two together to only use one copy of the File Format for RARC (the RARCPacker one).

The only functionality I use from the original Kazari.RARC is loading an archive from file, decompressing it (if compressed), and then iterating through the File Nodes and File Entries. If this functionality could be added to the RARCPacker class (and then that renamed) that'd be great.

Proposal:
RARCPacker.cs -> Source\FileFormats\RArc.cs
class RARCPacker -> class RARC
struct RarcHeader -> Header (since its already in the Rarc class you'd use it via Rarc.Header)
Expose a single method for Compressing a Directory and returning an RARC class. The rest of the fields can be marked as private - perhaps:
public static RARC CreatePackedArchive(string folder), inside the RARC class. Then usage would be:
RARC newArc = RARC.CreatePackedArchive(folder);

Issues:
Several references to existing RARC stuff across the project. Most will be removed when the RevisedArcLoading branch is merged into Master but until then it'll have to fit with the existing stuff.

Thanks!

@ghost ghost assigned pho Jan 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants