Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ig.Loader requires unnecessary modules? #47

Open
Joncom opened this issue Aug 4, 2019 · 0 comments
Open

ig.Loader requires unnecessary modules? #47

Joncom opened this issue Aug 4, 2019 · 0 comments

Comments

@Joncom
Copy link
Collaborator

Joncom commented Aug 4, 2019

.requires(
'impact.image',
'impact.font',
'impact.sound'
)

As far as I can tell, none of these are actually used within the ig.Loader class/module...

Edit:

It's for sure possible to have a game that doesn't use any ig.Font, but by requiring it here, the font code will still get baked into the final output, unnecessarily.

One could argue that some of those required modules do get used in the loader, because they are populated into the resources array, and then manipulated via methods such as .load...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant