New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ig.Entity._wmInEditor property? #55

Open

Joncom opened this issue Aug 24, 2019 · 0 comments

Collaborator

Joncom commented Aug 24, 2019 •

edited

Loading

Impact/lib/weltmeister/edit-entities.js

Line 343 in 425cbc1

newEntity._wmInEditor = true;

As far as I can tell this doesn't get used anywhere...

Furthermore, there are other ways of detecting if the editor is running:

if( ig.global.wm ) { /* running weltmeister */ }
if( ig.editor ) { /* running weltmeister */ }

Is there really any need to add this information to every single entity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment