-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring dependencies up to date #8
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing this @matthiasfabry!
I ran into a few issues while testing that we should try to resolve before merging:
- anchor links seem to not be working, for example: https://phoebe-project.org/clients#desktop
- workshops page seems to be broken (possibly could be because of trying to load remote images from the server?)
- header links at the top of
/docs
is not loading the correct version string and pointing to/docs/null/tutorials
, etc, instead - publications subpages are broken (https://phoebe-project.org/publications/2005Prsa+, for example)
- dropdowns under "develop" and "help" in navbar are broken (perhaps because of missing jquery?)
styling is off now, but functionality should be ok
These commits fix most of the problems mentioned above. Albeit with messing up the styling somewhat. I'm at a loss on how to style the |
Yes, static files are hosted separately, so if the images are the only problem, that's probably ok. We can also try with the full absolute links instead to at least test if they're working |
Closes https://github.com/phoebe-project/phoebe-development/issues/111