Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency tree outdated #27

Open
matthiasfabry opened this issue Sep 3, 2024 · 3 comments · May be fixed by #28
Open

Dependency tree outdated #27

matthiasfabry opened this issue Sep 3, 2024 · 3 comments · May be fixed by #28
Assignees
@matthiasfabry

Comments

@matthiasfabry
Copy link

Hi everyone,

I'm trying to get the UI built on my Intel Mac, but it seems that the dependency tree is not up to date anymore:

$ npm install
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/react
npm error   react@"16.6.3" from the root project
npm error
npm error Could not resolve dependency:
npm error peer react@"^15.3.0" from [email protected]
npm error node_modules/react-query-params
npm error   react-query-params@"1.0.9" from the root project

query-params was made for 15.3.0, while the top-level requirement is 16.6.3. Downgrading the top-level requirement breaks other dependencies.
Unfortunately I've no Node or JS experience so I do not know what each package's functions is/are, nor do I know which packages to update/change. A simple search on npm shows query-params hasn't been updated for 6 years.
@kecnry
Copy link
Member

kecnry commented Sep 5, 2024

Thanks for reporting this - I'll make sure this is on our list, but unfortunately we don't have anyone able to commit significant resources to maintaining the UI at this time. If you or anyone is interested in tackling this and wants some help, please reach out and I'd be happy to help get you started.

Are you trying to install from the latest release build or from the source code itself?

@matthiasfabry
Copy link
Author

yes, I'm happy to help. I'm of the opinion that if the UI works well, we can extend the reach of PHOEBE. I'm trying to build from source, as I cannot get the pre-built version to work, see #16.

@kecnry
Copy link
Member

kecnry commented Sep 5, 2024

Long term, what we probably need to do is update as many of the packages as possible to most recent releases and update anything within the source code that is needed to do so, but that will likely take a significant effort. Currently, phoebe's package.json pins specific versions of dependencies to avoid conflicts, but as you noticed, these are now quite outdated. I'm not sure why there is now a conflict between the pinned version of react and the requirement from react-query-params 1.0.9, when that used to work without problems. The easier task for now might be to just find versions of react and react-query-params that are compatible with each other with minimal changes (if any) to the code in the phoebe UI.

This document is useful for understanding the syntax of version requirements: https://github.com/npm/node-semver?tab=readme-ov-file#advanced-range-syntax

@kecnry kecnry mentioned this issue Sep 17, 2024
Closed
@kecnry kecnry linked a pull request Oct 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthiasfabry matthiasfabry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependency tree matthiasfabry/phoebe2-ui
2 participants
@kecnry @matthiasfabry