Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sinusoidal Intensities feature #892

Draft
wants to merge 3 commits into
base: release-2.5
Choose a base branch
from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jun 11, 2024

this PR implements:

  • the ability for (component) features to hook into and modify mesh intensities
  • a new feature that adds a sinusoidal perturbation term to the mesh intensities before eclipsing/integration
import phoebe

b = phoebe.default_binary()
b.add_dataset('lc', compute_phases=phoebe.linspace(0,1,101))
b.run_compute(model='without_puls')

b.add_feature('sinusoidal_intensities', component='primary', feature='puls01')
b.set_value('period@puls01', 0.25)
b.set_value('amplitude', 0.2)

b.run_compute(model='with_puls')
b.plot(save='sinusoidal_intensities.png')

test

TODO:

  • fix issue with reloading bundle after saving with feature added (requiv filter somewhere needs to set the context)
  • test coverage
  • t0@feature parameter with default constraint to t0@system
  • documentation
  • test coverage
  • consider as time dependent unless same period (or fraction) as orbital period AND parent star is synchronous?

@kecnry kecnry changed the base branch from master to release-2.5 June 11, 2024 12:46
@kecnry kecnry mentioned this pull request Jun 13, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant