Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velph phelel vs supercell naming conflict #28

Open
mystery-e204 opened this issue Sep 24, 2024 · 1 comment
Open

velph phelel vs supercell naming conflict #28

mystery-e204 opened this issue Sep 24, 2024 · 1 comment

Comments

@mystery-e204
Copy link

When running velph phelel init, a directory named phelel is created. However, when creating a self-energy calculation from this supercell data via velph elph generate, it assumes that the directory is called supercell (which was the case in the past). I think this should be consistently called phelel as well.

atztogo added a commit that referenced this issue Sep 25, 2024
atztogo added a commit that referenced this issue Sep 25, 2024
Fix velph-selfenergy-generate (issue #28)
@atztogo
Copy link
Contributor

atztogo commented Sep 25, 2024

Thanks for your report. I think it is fixed by PR #29. I should write a test. But I don't have a good idea how to write the test for those commands systematically. Probably in the future I will work on it.

Note, in addition, I changed the command name from velph-elph to velph-transport. See #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants