Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: do not parse wikilinks existing within pre or code tags #53

Open
carbontwelve opened this issue May 10, 2024 · 3 comments · Fixed by #64
Open

BUG: do not parse wikilinks existing within pre or code tags #53

carbontwelve opened this issue May 10, 2024 · 3 comments · Fixed by #64
Assignees
@carbontwelve
Labels
bug Something isn't working
Milestone
v1.1.1

Comments

@carbontwelve
Copy link
Contributor

carbontwelve commented May 10, 2024 •
edited
Loading

Where I have some wiki link examples within my blog I am seeing the interlinker error on parsing them, going so far as to throw an error due to both the "linked" page and identified resolving function not existing.

image
@carbontwelve carbontwelve added the bug Something isn't working label May 10, 2024
@carbontwelve carbontwelve added this to the v1.1.0 milestone May 10, 2024
@carbontwelve carbontwelve self-assigned this Oct 25, 2024
carbontwelve added a commit that referenced this issue Nov 7, 2024
@carbontwelve
feat(#53): add test for markdown parser ignoring wikilink within code…
f3dc0a5 
… blocks
carbontwelve added a commit that referenced this issue Nov 7, 2024
@carbontwelve
TDD(#53): add failing test for feature
f22cb1b
carbontwelve added a commit that referenced this issue Nov 7, 2024
@carbontwelve
chore(#53): require jsdom
4fec5db
carbontwelve added a commit that referenced this issue Nov 7, 2024
@carbontwelve
chore(#53): fix typo
81589a0
carbontwelve added a commit that referenced this issue Nov 7, 2024
@carbontwelve
feat(#53): use JSDOM to parse internal anchor tags
939e151
@carbontwelve carbontwelve mentioned this issue Nov 7, 2024
Merged
carbontwelve added a commit that referenced this issue Nov 7, 2024
@carbontwelve
Merge pull request #64 from photogabble/patch/v1.1.0/#53
3f81a6a 
BUGFIX: Do not parse anchor tags within code blocks
@carbontwelve
Copy link
Contributor Author

I thought I had fixed this in #64, however when testing with my 11ty install it's still picking up both wikilinks and html anchors that are within pre or code blocks. Needs further investigation because when running the markdown checker directly it excludes wikilink lookup from within code blocks, where as it appears that when run from 11ty it doesn't...

@carbontwelve
Copy link
Contributor Author

This is related to #65. Where I am using the inline rule it's unaware it's running inside a code block. Switching to a block rule may fix this issue as well.

carbontwelve added a commit that referenced this issue Dec 2, 2024
@carbontwelve
chore(#53): additional test for parsing outside of code blocks
6b61fae
@carbontwelve
Copy link
Contributor Author

The markdown rules correctly ignore wikilinks found within code blocks (either <pre> or <code>) however the wikilink identification code doesn't.

I'm moving this to the next milestone so that it stops blocking the v1.1.0 release and will work on it as the next priority.

@carbontwelve carbontwelve modified the milestones: v1.1.0, v1.1.1 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carbontwelve carbontwelve

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging a pull request may close this issue.

BUGFIX: Do not parse anchor tags within code blocks photogabble/eleventy-plugin-interlinker
1 participant
@carbontwelve